[workflow] Deprecate workflow.create #26106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suquark
force-pushed
the
deprecate_workflow_create
branch
from
e723c89
to
b87ba3d
Compare
suquark
requested review from
ericl,
fishbone,
stephanie-wang and
maxpumperla
as code owners
fishbone
reviewed
Jun 30, 2022
fishbone
reviewed
Jun 30, 2022
fishbone
reviewed
Jun 30, 2022
|
|
||
| Dynamic workflows | ||
| ----------------- | ||
|
|
||
| Additional tasks can be dynamically created and inserted into the workflow DAG during execution. | ||
|
|
||
| This is achieved by returning a continuation of a DAG. | ||
| A continuation is something returned by a function and executed after it returns. | ||
|
|
||
| In our context, a continuation is basically a tail function call returned by a function. For example: |
There was a problem hiding this comment.
Maybe also adds a sentence about how the continuation behaves in ray core engine.
There was a problem hiding this comment.
hmmm, I do not want to mention how a DAG is executed by default in Ray core engine. I feel this complicates the topic.
fishbone
added
the
@author-action-required
suquark
removed
the
@author-action-required
fishbone
approved these changes
Jul 2, 2022
|
fishbone
added
the
@author-action-required
suquark
removed
the
@author-action-required
|
The failed CI test seems unrelated. I'll merge the PR. |
truelegion47
pushed a commit
to truelegion47/ray
that referenced
this pull request
Jul 6, 2022
* master: (104 commits) [Serve] Java Client API and End to End Tests (ray-project#22726) [Docs] Small fix to AIR examples descriptions (ray-project#26227) [Deployment Graph] Move `Deployment` creation outside to build function (ray-project#26129) [K8s][Ray Operator] Ignore resource requests when detected container resources. (ray-project#26234) Revert "[Core] Add retry exception allowlist for user-defined filteri… (ray-project#26289) [ci] pin gpustat (ray-project#26311) [tune] fix `set_tune_experiment` (ray-project#26298) Revert "Revert "[AIR][Serve] Rename ModelWrapperDeployment -> PredictorDeployment"" (ray-project#26231) [Release] Use nightly base images for release tests (ray-project#25373) Revert "[Core] fix gRPC handlers' unlimited active calls configuration (ray-project#25626)" (ray-project#26202) [RLlib] Some Docs fixes (2). (ray-project#26265) [C++ worker] Refine worker context and more (ray-project#26281) Fix file_system_monitor.cc message (ray-project#26143) [Java] Make Java test more stable (ray-project#26282) [air] Do not warn of `checkpoint_dir` if it's coming from us (base_trainer). (ray-project#26259) [Datasets] Support drop_columns API (ray-project#26200) [Datasets] Fix max number of actors for default actor pool strategy (ray-project#26266) [ci] Stop syncer staging tests (ray-project#26273) [core][gcs] Add storage namespace to redis storage in GCS. (ray-project#25994) [workflow] Deprecate workflow.create (ray-project#26106) ...
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
Signed-off-by: Edward Oakes <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
Signed-off-by: klwuibm <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Frank Luan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After deprecating
Workflowclass in #25618 ,workflow.createbecomes a redundant API and should be deprecated.We update examples and docs correspondingly.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.