[Serve] Allow and remove trailing slashes in Ray submission address #26093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
reviewed
Jun 24, 2022
dashboard/modules/dashboard_sdk.py
Outdated
Comment on lines
193
to
198
| self._address = cluster_info.address.rstrip("/") | ||
| logger.debug( | ||
| "The submission address cannot contain trailing slashes. Removing " | ||
| f'them from the requested submission address of "{address}".' | ||
| ) | ||
|
|
There was a problem hiding this comment.
guard this with if cluster_info.address.endswith("/")?
There was a problem hiding this comment.
Good catch– I added a guard.
simon-mo
approved these changes
Jun 25, 2022
|
@simon-mo This change will also affect the job submission path, since I'm modifying the parent class. Do you think that'll be okay? |
|
I'm not sure, probably? @architkulkarni thoughts? |
architkulkarni
approved these changes
Jun 27, 2022
wuisawesome
approved these changes
Jun 29, 2022
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
…ay-project#26093) Signed-off-by: Edward Oakes <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
…ay-project#26093) Signed-off-by: klwuibm <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…ay-project#26093) Signed-off-by: Frank Luan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change removes trailing slashes from a Ray submission address, rather than raising an
Exception. This reduces confusion over the format required for a Ray submission address.Related issue number
Closes #25969.
Checks
scripts/format.shto lint the changes in this PR.test_job_submission.pyandtest_cli.pyto submit to addresses with a trailing slash.