[docs] Update docs for building from source #26045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
reviewed
Jun 23, 2022
| @@ -143,11 +143,20 @@ To build Ray on Ubuntu, run the following commands: | |||
| .. code-block:: bash | |||
|
|
|||
| sudo apt-get update | |||
| sudo apt-get install -y build-essential curl unzip psmisc | |||
| sudo apt-get install -y build-essential curl gcc-9 g++-9 pkg-config psmisc unzip | |||
| sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-9 90 \ | |||
There was a problem hiding this comment.
seems this doesn't work for ubuntu 18.04 because of missing gcc 9 package.
There was a problem hiding this comment.
on ubuntu 18.04, you need add
sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test
before sudo apt-get update.
https://askubuntu.com/questions/1140183/install-gcc-9-on-ubuntu-18-04
|
friendly ping! |
|
I've pushed your comment but haven't had time to spin up 18.04 vm for manual testing (i'm using 22.04 these days) |
scv119
approved these changes
Jul 6, 2022
|
Thanks for the fix! |
3 tasks
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Edward Oakes <[email protected]>
nikitavemuri
pushed a commit
to nikitavemuri/ray
that referenced
this pull request
Jul 15, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Nikita Vemuri <[email protected]>
Catch-Bull
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 18, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Catch-Bull <[email protected]>
Catch-Bull
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 18, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Catch-Bull <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: klwuibm <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Frank Luan <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally). Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The existing docs didn't work for me and these updates did. 🤷♀️ I selectively pulled this stuff out of the CI (which ideally would just be runnable locally).
Related issue number
Checks
scripts/format.shto lint the changes in this PR.