Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime env] remove unused runtime env uris from protobuf #26001

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

SongGuyang
Copy link
Contributor

Why are these changes needed?

We only need working_dir_uri and py_modules_uris which are used for reference counting in GCS. Raylet and agent don't need the uris absolutely.

Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the improvement!

@architkulkarni
Copy link
Contributor

//python/ray/dashboard:modules/serve/tests/test_serve_head flaky on master and unrelated
tests:test_multi_node_3 flaky and unrelated
tests:test_shuffle flaky and unrelated
rllib:learning_tests_pendulum_cql flaky and unrelated

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 22, 2022
@raulchen raulchen merged commit a8ef296 into ray-project:master Jun 23, 2022
@raulchen raulchen deleted the dev_runtime_env branch June 23, 2022 02:45
edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants