[C++ API] add default_actor_lifetime param and add more exception info for cpp worker #25929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Should we add some test cases? |
yes,I will try add test cases. |
SongGuyang
requested changes
Jun 20, 2022
3ee91b8
to
63cd8c3
Compare
SongGuyang
reviewed
Jun 21, 2022
63cd8c3
to
a0a84a7
Compare
cpp/src/ray/config_internal.cc
Outdated
| @@ -129,6 +148,11 @@ void ConfigInternal::Init(RayConfig &config, int argc, char **argv) { | |||
| head_args.insert(head_args.end(), args.begin(), args.end()); | |||
| } | |||
| startup_token = absl::GetFlag<int64_t>(FLAGS_startup_token); | |||
| if (!FLAGS_ray_default_actor_lifetime.CurrentValue().empty()) { | |||
| std::cout << "xxxx"; | |||
82e3843
to
22cc120
Compare
SongGuyang
requested changes
Jun 22, 2022
SongGuyang
reviewed
Jun 22, 2022
9716918
to
47c0117
Compare
47c0117
to
aa92e6b
Compare
aa92e6b
to
6e36b52
Compare
raulchen
approved these changes
Jun 28, 2022
WangTaoTheTonic
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
add default_actor_lifetime param and add more exception info for cpp worker
Related issue number
Checks
scripts/format.shto lint the changes in this PR.