[api] Annotate as public / move ray-core APIs to _private and add enforcement rule #25695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
approved these changes
Jun 21, 2022
Given we're deprecating local mode, I think this may be something we can remove in the future. |
6 tasks
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
…orcement rule (ray-project#25695) Enable checking of the ray core module, excluding serve, workflows, and tune, in ./ci/lint/check_api_annotations.py. This required moving many files to ray._private and associated fixes.
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…orcement rule (ray-project#25695) Enable checking of the ray core module, excluding serve, workflows, and tune, in ./ci/lint/check_api_annotations.py. This required moving many files to ray._private and associated fixes. Signed-off-by: Frank Luan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Enable checking of the
raycore module, excluding serve, workflows, and tune, in./ci/lint/check_api_annotations.py. This required moving many files toray._privateand associated fixes.