[Serve][AIR] Support mixed input and output type, with batching #25688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekris-anyscale
requested changes
Jun 13, 2022
python/ray/serve/model_wrappers.py
Outdated
|
|
||
| # Check all input has the same dict keys. |
There was a problem hiding this comment.
Suggested change
| # Check all input has the same dict keys. | |
| # Check that all inputs have the same dict keys. |
python/ray/serve/model_wrappers.py
Outdated
| batch_has_same_keys = input_keys.count(input_keys[0]) == batch_size | ||
| if not batch_has_same_keys: | ||
| raise ValueError( | ||
| f"The input batch contains dictionary of different keys: {input_keys}" |
There was a problem hiding this comment.
Suggested change
| f"The input batch contains dictionary of different keys: {input_keys}" | |
| f"The input batch's dictionaries must each contain the same keys. Got different keys in some dictionaries: {input_keys}" |
python/ray/serve/model_wrappers.py
Outdated
| else: | ||
| raise ValueError( | ||
| "ModelWrapper only accepts numpy array or dataframe as input " | ||
| "ModelWrapper only accepts numpy array, dataframe, or dict of " | ||
| "array as input " |
There was a problem hiding this comment.
Suggested change
| "array as input " | |
| "arrays as input " |
shrekris-anyscale
approved these changes
Jun 14, 2022
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
…project#25688) Signed-off-by: Edward Oakes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For AIR Predictor interface conformance. The predictor support input any data batch type and output any type, not necessary matching input and output type. This PR refactored how model wrapper does batching and splitting to support that.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.