Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR][Serve] Accept predictor.predict kwargs in init #25537

Merged
merged 3 commits into from
Jun 13, 2022
Merged

[AIR][Serve] Accept predictor.predict kwargs in init #25537

merged 3 commits into from
Jun 13, 2022

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Jun 7, 2022 •
edited
Loading

Why are these changes needed?

Ray AIR predictor interface supports optional kwargs in its predictor. This PR adds compatibility for that.

Closes #25470

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw richardliaw added this to the Ray AIR milestone Jun 8, 2022
@simon-mo simon-mo marked this pull request as ready for review June 10, 2022 22:20
amogkam
amogkam approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@simon-mo simon-mo merged commit 7727dcd into ray-project:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

@shrekris-anyscale shrekris-anyscale

Labels
None yet
Projects
None yet
Milestone
Ray AIR
Development

Successfully merging this pull request may close these issues.

[Serve][Air] ModelWrapper should support kwargs via http_adapter
4 participants
@simon-mo @amogkam @richardliaw @shrekris-anyscale