Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add bazel py_test checking for Serve #25509

Merged
merged 7 commits into from
Jun 7, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jun 6, 2022

Why are these changes needed?

Extends the if __name__... snippet test to Serve tests.

The following files are missing it:

python/ray/serve/tests/test_model_wrappers.py
python/ray/serve/tests/test_logs.py
python/ray/serve/tests/test_http_adapters.py

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 requested a review from simon-mo June 6, 2022 17:03
ci/ci.sh Outdated Show resolved Hide resolved
@Yard1 Yard1 changed the title [CI] Add bazel py_test checking for serve [CI] Add bazel py_test checking for Serve Jun 6, 2022
python/ray/serve/BUILD Outdated Show resolved Hide resolved
@simon-mo
Copy link
Contributor

simon-mo commented Jun 7, 2022

lint and serve passed!

@simon-mo simon-mo merged commit 3876fcd into ray-project:master Jun 7, 2022
@Yard1 Yard1 deleted the pytest_checking_for_serve branch June 7, 2022 18:03
sumanthratna pushed a commit to sumanthratna/ray that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants