[datasets] Fix scheduling strategy propagation and stats collection in push-based shuffle #25108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
approved these changes
May 23, 2022
| @@ -138,6 +138,7 @@ def execute( | |||
| # The placement strategy for reduce tasks is overwritten to colocate | |||
| # them with their inputs from the merge stage, so remove any | |||
| # pre-specified scheduling strategy here. | |||
| reduce_ray_remote_args = reduce_ray_remote_args.copy() | |||
python/ray/data/tests/test_sort.py
Outdated
| # Check all merge tasks are included in stats. | ||
| internal_stats = ds._plan.stats() | ||
| num_merge_tasks = len(internal_stats.stages["random_shuffle_merge"]) | ||
| assert parallelism // 3 <= num_merge_tasks <= parallelism // 2 |
There was a problem hiding this comment.
is 2 the merge factor? maybe rename it to a constant for easier understanding.
mwtian
approved these changes
May 24, 2022
jjyao
approved these changes
May 24, 2022
jianoaix
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes two bugs in Datasets push-based shuffle:
Related issue number
Issue 1 is necessary for performance at large-scale (#24480).
Checks
scripts/format.shto lint the changes in this PR.