[Java] Remove RayRuntimeInternal class #25016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfstorm
approved these changes
May 23, 2022
| @@ -33,7 +33,6 @@ public RayDevRuntime(RayConfig rayConfig) { | |||
| super(rayConfig); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Why remove these in RayDevRuntime? I believe the methods are defined in AbstractRayRuntime.
There was a problem hiding this comment.
Good catch. They are introduced unintended. FIxed.
|
This only changes Java part. Failure tests are not related. |
16 tasks
krfricke
added a commit
that referenced
this pull request
May 24, 2022
jovany-wang
added a commit
to jovany-wang/ray
that referenced
this pull request
May 24, 2022
…5016)" (ray-project#25139)" This reverts commit 804b6b1.
jovany-wang
added a commit
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Due to we have already removed the multiple workers in one process, remove RayRuntimeInternal for purpose.
Related issue number
#24567
Checks
scripts/format.shto lint the changes in this PR.