Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python3.10] Build py310 images #24859

Merged
merged 16 commits into from
May 18, 2022
Merged

[python3.10] Build py310 images #24859

merged 16 commits into from
May 18, 2022

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented May 16, 2022 •
edited
Loading

Why are these changes needed?

Build python 3.10 images so we can run release tests.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review May 16, 2022 20:18
amogkam
amogkam approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm if tests pass!

Also seems like some release test changes were accidentally pushed?

@amogkam
Copy link
Contributor

amogkam commented May 16, 2022

@scv119 before merging this in, we also need to update the ray/docker/retag-lambda/python_versions.txt file.

@scv119 scv119 added the do-not-merge Do not merge this PR! label May 17, 2022
krfricke
krfricke approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, failing wheel build will be resolved once merged

@scv119 scv119 added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed do-not-merge Do not merge this PR! labels May 18, 2022
@scv119 scv119 merged commit 1325cf7 into ray-project:master May 18, 2022
scv119 added a commit to scv119/ray that referenced this pull request May 18, 2022
@scv119
[python3.10] Build py310 images (ray-project#24859)
b4881e9 
Build python 3.10 images so we can run release tests.
scv119 added a commit that referenced this pull request May 18, 2022
@scv119 @krfricke
[Cherry-pick] Add necessary build changes to build python3.10 docker …
002a2b8 
…images (#24929)

* [python3.10] Build py310 images (#24859)

Build python 3.10 images so we can run release tests.

* [ci/py310] Fix docker image build/tag (#24922)

We're currently not building the 3.9/3.10 ray-ml docker images, but we're still trying to tag/push them.

Co-authored-by: Kai Fricke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

@krfricke krfricke krfricke approved these changes

@mwtian mwtian mwtian approved these changes

Assignees

@krfricke krfricke

@rkooo567 rkooo567

@mwtian mwtian

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scv119 @amogkam @krfricke @mwtian @rkooo567