Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] Fix black version check in ci/lint/format.sh #24852

Merged
merged 5 commits into from
May 16, 2022
Merged

[minor] Fix black version check in ci/lint/format.sh #24852

merged 5 commits into from
May 16, 2022

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented May 16, 2022 •
edited
Loading

Why are these changes needed?

Apparently the black version string differs based on installation method. On my (m1) laptop:

$ black --version
black, version 21.7b0

On @simon-mo's (intel) and @shrekris-anyscale's (m1) laptops:

$ black --version
black, 21.12b0 (compiled: no)

This adds a conditional in ci/lint/format.sh to handle both.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Contributor

simon-mo commented May 16, 2022 •
edited
Loading

... actually on my laptop

➜  ~ black --version
black, 21.12b0 (compiled: no)

➜  ~ black --version | awk '{print $3}'
(compiled:

@edoakes
Copy link
Contributor Author

edoakes commented May 16, 2022

@simon-mo 🤦‍♂️

I updated it to check if running on arm.

@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 16, 2022
@edoakes
Copy link
Contributor Author

edoakes commented May 16, 2022

aaaaand it's not actually intel vs. arm, updated again.

@edoakes edoakes merged commit 86422a5 into ray-project:master May 16, 2022
maxpumperla pushed a commit that referenced this pull request May 18, 2022
@edoakes @maxpumperla
[minor] Fix black version check in ci/lint/format.sh (#24852)
264b1dd 
The `black` version string differs based on installation method. On my (m1) laptop:
```
$ black --version
black, version 21.7b0
```

On @simon-mo's (intel) and @shrekris-anyscale's (m1) laptops:
```
$ black --version
black, 21.12b0 (compiled: no)
```

This adds a conditional in `ci/lint/format.sh` to handle both.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@simon-mo simon-mo simon-mo approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

@ericl ericl Awaiting requested review from ericl

Assignees

@simon-mo simon-mo

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edoakes @simon-mo @richardliaw @shrekris-anyscale