[ci/docs] Add doc maintainer to CODEOWNERs for doc #24778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpumperla
reviewed
May 13, 2022
| @@ -56,11 +56,11 @@ | |||
|
|
|||
| # Ray data. | |||
| /python/ray/data/ @ericl @scv119 @clarkzinzow @jjyao | |||
| /doc/source/data/ @ericl @scv119 @clarkzinzow @jjyao | |||
| /doc/source/data/ @ericl @scv119 @clarkzinzow @jjyao @maxpumperla | |||
There was a problem hiding this comment.
thanks @krfricke ! We should maybe think about following this up with a PR that deletes these two specific lines and adds 3-4 maintainers of the whole /doc package.
We've had a couple of unnecessary regressions / deviations that I'd like to put a safeguard on.
There was a problem hiding this comment.
+1 that would be preferable to me
There was a problem hiding this comment.
Sounds good - let's do this in a follow up? It would be great if you could suggest these people @maxpumperla
ericl
approved these changes
May 15, 2022
ericl
added
the
@author-action-required
maxpumperla
pushed a commit
that referenced
this pull request
May 18, 2022
e2ee214 broke linter on master. However, reverting the commit or hotfixing the docs requires codeowner approval. It makes sense to include @maxpumperla as a codeowner in doc-related code paths, so this PR adds him.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
e2ee214 broke linter on master. However, reverting the commit or hotfixing the docs requires codeowner approval. It makes sense to include @maxpumperla as a codeowner in doc-related code paths, so this PR adds him.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.