Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] QMix TrainerConfig objects. #24775

Merged
merged 8 commits into from
May 13, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 13, 2022

QMix TrainerConfig objects.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sven1977 sven1977 merged commit 8fe3fd8 into ray-project:master May 13, 2022
simon-mo added a commit to simon-mo/ray that referenced this pull request May 13, 2022
simon-mo added a commit to simon-mo/ray that referenced this pull request May 13, 2022
"""

def __init__(self):
"""Initializes a PPOConfig instance."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Initializes a PPOConfig instance."""
"""Initializes a QMixConfig instance."""

@sven1977 sven1977 deleted the qmix_config_objects branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants