[Serve/Doc] Add combine nodes with same input in parallel pattern #24760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaodong
reviewed
May 13, 2022
doc/source/serve/doc_code/deployment_graph_combine_two_nodes_with_passing_input_parallel.py
Outdated
Show resolved
Hide resolved
jiaodong
reviewed
May 13, 2022
doc/source/serve/doc_code/deployment_graph_combine_two_nodes_with_passing_input_parallel.py
Outdated
Show resolved
Hide resolved
|
I didn't see this new section shows up on the index |
jiaodong
reviewed
May 13, 2022
54c8f35
to
623d226
Compare
jiaodong
reviewed
May 16, 2022
|
|
||
| @serve.deployment | ||
| def combine(value_refs): | ||
| return sum(ray.get(value_refs)) |
There was a problem hiding this comment.
as a follow-up, we should do a simple benchmark on the wide fanout pattern with larger intermediate data size (let's say 50MB) and ensure the added latency makes sense and confirm we're not:
- Making redundant copies of data
- Not leaking memory over time with repeated execution
There was a problem hiding this comment.
Sg! I will take it as a separate task, not going to follow up in this pr.
|
Doc test passed. Lint also. Merging |
maxpumperla
pushed a commit
that referenced
this pull request
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add one more pattern for deployment graph
Related issue number
Checks
scripts/format.shto lint the changes in this PR.