-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RuntimeEnv][Java] Support runtime env jars for job. #24725
Merged
jovany-wang
merged 37 commits into
ray-project:master
from
jovany-wang:java-jars-for-job
May 16, 2022
Merged
[RuntimeEnv][Java] Support runtime env jars for job. #24725
jovany-wang
merged 37 commits into
ray-project:master
from
jovany-wang:java-jars-for-job
May 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be merged after #24712 due to we refine the tests. |
raulchen
approved these changes
May 16, 2022
// Note that it supports both jar packages and zip packages. | ||
"jars": [ | ||
// "https://my_host.a.jar", | ||
// "https://my_host.b.jar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// "https://my_host.b.jar" | |
// "https://my_host/b.jar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to all CI cases get green, I'm merging this PR and then change the typo later.
maxpumperla
pushed a commit
that referenced
this pull request
May 18, 2022
This PR supports specifying the jars(or zip packages) for a job, which are used for all workers for this job. You can specify jars or zips in the config file of your job: ```yml ray { job { runtime-env: { "jars": [ "https://my_host/a.jar", "https://my_host/b.jar" ] } } } ``` or via system properties: ```java System.setProperty("ray.job.runtime-env.jars.0", "https://my_host/a.jar"); System.setProperty("ray.job.runtime-env.jars.1", "https://my_host/a.jar"); Ray.init(); // all workers of this job will add a.jar and b.jar into the classpath. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR supports specifying the jars(or zip packages) for a job, which are used for all workers for this job.
You can specify jars or zips in the config file of your job:
or via system properties:
Related issue number
#21463
Checks
scripts/format.sh
to lint the changes in this PR.