[Workflow] Simplify recovery algorithm #24594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@suquark could you add more details in description area about what you did here? |
|
Also, does this also support cancellation if we store the execution queue in the workflow manager? |
fishbone
added
the
@author-action-required
suquark
removed
the
@author-action-required
|
@iycheng what kind of cancellation you want? If you would like to cancel the "construct the workflow for recovery" process, then yes this PR makes it possible; but it does not directly enables cancelling of a "already recovering" workflow. However, this PR would still be a necessary starting point for fully supporting workflow cancelling. Later I would also refactor the workflow execution code like this, and they would share a few code. |
fishbone
approved these changes
May 10, 2022
|
The CI errors are not related. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The workflow recovery algorithm was originally implemented with recursions, this makes it harder to check, maintain and optimize, because you only debug variables in the current stack frames, and there are potential risks of stack overflow due to recursion. This also results in duplicated code between
_reconstruct_wait_stepand_construct_resume_workflow_from_step.This PR simplifies the workflow recovery algorithm. It's now easier to check, maintain and optimize. The recovery algorithm is divided into 3 steps in a clean way:
Checks
scripts/format.shto lint the changes in this PR.