[core] More tests for setting options for Ray libraries #24591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
reviewed
May 9, 2022
Comment on lines
+342
to
+344
| # TODO(suquark): The current implementation of `.options()` is so bad that we | ||
| # cannot even access its options from outside. Here we hack the closures to | ||
| # achieve our goal. Need futher efforts to clean up the tech debt. |
|
cc @jiaodong @sihanwang41 this is how |
|
The CI errors seem not related. I'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
More tests for setting options for Ray libraries. This mechanic is currently used by workflow and serve.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.