[core] Update metadata in options properly #24458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
_metadata
is a special keyword in Ray options that contains multiple namespaces. It is intended for config of different Ray libraries. However, current updating of options is incorrect for_metadata
: it replaces all contents in_metadata
, but what we really want is updating each namespace independently. For example:This PR fixes this issue.
With this fix, we can support the follow syntax for updating workflow options:
Checks
scripts/format.sh
to lint the changes in this PR.