Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime env] Add FAQ for runtime_env #24412

Merged
merged 13 commits into from
May 13, 2022
Merged

[runtime env] Add FAQ for runtime_env #24412

merged 13 commits into from
May 13, 2022

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented May 2, 2022 •
edited
Loading

Why are these changes needed?

Adds some frequently asked user questions to the docs.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni
Copy link
Contributor Author

Screen Shot 2022-05-09 at 2 36 45 PM

Doc build passed

@architkulkarni architkulkarni marked this pull request as ready for review May 9, 2022 21:37
shrekris-anyscale
shrekris-anyscale requested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! I posted some clarifying questions and comments. I think this FAQ will help alleviate some common questions.

@architkulkarni
Copy link
Contributor Author

Thanks for the careful review @shrekris-anyscale, I addressed the comments

shrekris-anyscale
shrekris-anyscale approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates– the changes look good!

edoakes
edoakes approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@edoakes
Copy link
Contributor

edoakes commented May 10, 2022

@shrekris-anyscale thanks for the detailed review here

@architkulkarni
Copy link
Contributor Author

Docs build passed and this is a docs-only change

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label May 12, 2022
@edoakes edoakes merged commit 738da63 into ray-project:master May 13, 2022
maxpumperla pushed a commit that referenced this pull request May 18, 2022
@architkulkarni @shrekris-anyscale @maxpumperla
[runtime env] Add FAQ for runtime_env (#24412)
cd8d60e 
Adds some frequently asked user questions to the docs.

Co-authored-by: shrekris-anyscale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

@shrekris-anyscale shrekris-anyscale shrekris-anyscale approved these changes

Assignees

@edoakes edoakes

@shrekris-anyscale shrekris-anyscale

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@architkulkarni @edoakes @shrekris-anyscale