Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix GPU docker builds #24336

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

NVIDIA Docker builds are currently broken, e.g.: https://buildkite.com/ray-project/ray-builders-branch/builds/7239#e9dea1d6-7dea-4323-801c-b7efe917be03

Following this workaround: https://forums.developer.nvidia.com/t/invalid-public-key-for-cuda-apt-repository/212901/11
to hopefully fix this for now.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kai! Let's see if build succeeds.

@krfricke krfricke merged commit 6282090 into ray-project:master Apr 29, 2022
@krfricke krfricke deleted the ci/fix-docker-build branch April 29, 2022 16:10
krfricke added a commit that referenced this pull request May 3, 2022
krfricke added a commit that referenced this pull request Jan 20, 2023
* Revert "[ci] Fix GPU docker builds (#24336)"

This reverts commit 6282090.

Removes custom APT keys from GPU docker images.

Signed-off-by: Kai Fricke <[email protected]>
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
* Revert "[ci] Fix GPU docker builds (ray-project#24336)"

This reverts commit 6282090.

Removes custom APT keys from GPU docker images.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Andrea Pisoni <[email protected]>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
* Revert "[ci] Fix GPU docker builds (ray-project#24336)"

This reverts commit 6282090.

Removes custom APT keys from GPU docker images.

Signed-off-by: Kai Fricke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants