Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump Bazel version to 4.2.2 #24242

Merged
merged 11 commits into from
May 27, 2022

Conversation

shrekris-anyscale
Copy link
Contributor

@shrekris-anyscale shrekris-anyscale commented Apr 26, 2022

Why are these changes needed?

A compatibility issue between Bazel, Protoc, and MacOS Monterey is solved starting in Bazel 4.2.2. This change upgrades the Bazel version from 4.2.1 to 4.2.2.

Related issue number

Closes #24241.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also double check if there is any public doc that references 4.2.1?

@shrekris-anyscale
Copy link
Contributor Author

shrekris-anyscale commented Apr 27, 2022

It looks like the Windows tests are failing. I'll investigate further, but there's a chance that Windows should continue using Bazel 4.2.1.

Depending on that, we may/may not want to change this line and this line in the docs.

@shrekris-anyscale
Copy link
Contributor Author

Could you also double check if there is any public doc that references 4.2.1?

@jjyao Good idea! I didn't notice any public doc that references 4.2.1 other than the lines about Windows I mentioned here.

@shrekris-anyscale
Copy link
Contributor Author

I made a PR in the buildkite-ci-stack repo to upgrade the Windows' CI Bazel version to 4.2.2. I also updated the references in the Windows docs to refer to Bazel 4.2.2 instead of 4.2.1.

Once the buildkite-ci-stack PR is merged, the Windows tests on this PR should pass.

@shrekris-anyscale
Copy link
Contributor Author

As a status update– we ran the packer command to update Bazel for Windows. However, the packer script ran into some issues:

==> amazon-ebs.ci-windows: The command 'powershell -Command $ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; ./main.ps1' returned a non-zero code: 1

See here for full command output.

Once this issue is resolved, we can finish the Windows Bazel update and then merge in this change.

@pdames
Copy link
Member

pdames commented May 7, 2022

+1 to getting this PR finalized and merged ASAP. I just went through the same discovery and troubleshooting process on MacOS Monterey and was about to submit the same PR before finding this one.

@shrekris-anyscale shrekris-anyscale changed the title [CI] Bump Bazel version to 4.2.2 [CI] Bump Bazel version to 4.2.2 on all operating systems except Windows May 26, 2022
@shrekris-anyscale shrekris-anyscale changed the title [CI] Bump Bazel version to 4.2.2 on all operating systems except Windows [CI] Bump Bazel version to 4.2.2 May 26, 2022
@simon-mo simon-mo merged commit 3234fd3 into ray-project:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Use Bazel version 4.2.2 instead of 4.2.1 for MacOS Monterey
5 participants