Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade arrow to include the plasma TensorFlow op #2412

Merged
merged 6 commits into from
Jul 18, 2018

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Jul 17, 2018

The main change in arrow relevant here is apache/arrow#2104

Can be built in the following way:

import ray
import pyarrow.plasma as plasma

plasma.build_plasma_tensorflow_op()

and then used as shown in https://github.com/pschafhalter/arrow/blob/50c66352ea87aa985ac0d70f6ea97c1f7423bd92/python/pyarrow/tests/test_plasma_tf_op.py

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6677/
Test FAILed.

@robertnishihara
Copy link
Collaborator

@pcmoritz Does this build the TF op? How does the user use the op?

@pcmoritz
Copy link
Contributor Author

I activated compiling the op now, an example usage is here: https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_plasma_tf_op.py

It should be tested out/maybe a test added before this is merged.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6682/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6687/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6690/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6691/
Test FAILed.

@pcmoritz
Copy link
Contributor Author

jenkins retest this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6693/
Test FAILed.

@pcmoritz
Copy link
Contributor Author

jenkins retest this please

@@ -2,6 +2,8 @@ set(GFLAGS_VERSION "2.2.0")
set(GTEST_VERSION "1.8.0")
set(GBENCHMARK_VERSION "1.1.0")

set(EP_CXX_FLAGS "${EP_CXX_FLAGS} -D_GLIBCXX_USE_CXX11_ABI=0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document

Copy link
Collaborator

@robertnishihara robertnishihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please address the minor comments and then we can merge it.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6697/
Test PASSed.

@robertnishihara robertnishihara merged commit 4c82ac7 into ray-project:master Jul 18, 2018
@robertnishihara robertnishihara deleted the tf-op branch July 18, 2018 19:33
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6698/
Test FAILed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants