[Serve] ensure replica reconfigure runs after allocation check #24052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since remote calls provide no ordering guarantees, it could happen that
reconfigure
gets called beforeis_allocated
Sincereconfigure
then runs the user initialization code, the replica actor could get blocked and never provide its allocation check.This PR ensures that the allocation proof has been received before we run the replica initialization.
I believe this approach is better than handling the ordering in the calling code (in deployment_state), since that would require the controller to poll the replica in order to make progress on the initialization.
Would we want a test for this? What would that look like?
Related issue number
#24044
Checks
scripts/format.sh
to lint the changes in this PR.