Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis port option to startup script #232

Merged
merged 6 commits into from
Jan 31, 2017
Merged

Add Redis port option to startup script #232

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0986c1
specify redis address when starting head
jssmith Jan 30, 2017
519ddd6
cleanup
jssmith Jan 31, 2017
e041919
update starting cluster documentation
jssmith Jan 31, 2017
933ea67
Whitespace.
robertnishihara Jan 31, 2017
beabd4f
Address Philipp's comments.
robertnishihara Jan 31, 2017
18de1ff
Change redis_host -> redis_ip_address.
robertnishihara Jan 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace.
  • Loading branch information
@robertnishihara
robertnishihara committed Jan 31, 2017
commit 933ea67ddffd8d0cbb047fe837ea4aa04a458695
3 changes: 2 additions & 1 deletion scripts/start_ray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ def check_no_existing_redis_clients(node_ip_address, redis_address):
print("Using IP address {} for this node.".format(node_ip_address))

if args.redis_port is not None:
address_info_in = { "redis_address" : "{}:{}".format(node_ip_address, args.redis_port) }
address_info_in = {"redis_address": "{}:{}".format(node_ip_address,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to call it address_info instead of address_info_in. I'm aware the name is also used below but it is not a problem, as it is explicitly updated like so:
address_info = function(address_info)

args.redis_port)}
else:
address_info_in = None

Expand Down