[dashboard] Remove redis in dashboard #22788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The next step is to remove ray core - python redis related code. And then I'll remove redis from |
ericl
approved these changes
Mar 3, 2022
mwtian
approved these changes
Mar 3, 2022
dashboard/head.py
Outdated
| @@ -220,24 +189,7 @@ def _load_modules(self): | |||
| return modules | |||
|
|
|||
| async def get_gcs_address(self): | |||
There was a problem hiding this comment.
Remove async keyword, or migrate callers to self.gcs_address?
I think redis path has some issues right now because we didn't test that :( and we'll need to fix it and add with redis path. So in the end, we'll test memory storage and redis storage code path. |
|
We'll fix that once booststrap and kv redis code paths are deleted. |
frosk1
pushed a commit
to frosk1/ray
that referenced
this pull request
Mar 9, 2022
As we are turning redisless ray by default, dashboard doesn't need to talk with redis anymore. Instead it should talk with gcs and gcs can talk with redis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As we are turning redisless ray by default, dashboard doesn't need to talk with redis anymore. Instead it should talk with gcs and gcs can talk with redis.
Clean up the code.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.