Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KubeRay] Remove configmap reference in example #22688

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Feb 28, 2022

Why are these changes needed?

A follow up change of #22348

example is not up to date and we can not bring up the cluster due to missing configmap. Autoscaler is able to convert CR to autoscaler config so we don't need configmap anymore.

Related issue number

Address #22687

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • I manually test this change

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 28, 2022

/cc @DmitriGekhtman

Copy link
Contributor

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DmitriGekhtman DmitriGekhtman merged commit 82daf2b into ray-project:master Feb 28, 2022
@Jeffwan Jeffwan deleted the fix_autoscaler_example branch March 1, 2022 00:28
@pcmoritz
Copy link
Contributor

pcmoritz commented Mar 4, 2022

Thank you so much for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants