Improve error messages when nodes can't communicate with each other. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertnishihara
changed the title
robertnishihara
changed the title
robertnishihara
force-pushed
the
fixes
branch
4 times, most recently
from
d95e111
to
dd91df5
Compare
robertnishihara
force-pushed
the
fixes
branch
from
dd91df5
to
642423b
Compare
richardliaw
commented
Jan 22, 2017
| @@ -674,7 +674,9 @@ def get_address_info_from_redis(redis_address, node_ip_address, num_retries=5): | |||
| if counter == num_retries: | |||
| raise | |||
| # Some of the information may not be in Redis yet, so wait a little bit. | |||
| print("Some processes that the driver needs to connect to have not registered with Redis, so retrying.") | |||
| print("Some processes that the driver needs to connect to have not " | |||
| "registered with Redis, so retrying. Have you run " | |||
There was a problem hiding this comment.
should this be placed outside the for loop?
There was a problem hiding this comment.
specifically the last part "have you tried..."
There was a problem hiding this comment.
I addressed this comment, but now I'm concerned that the user won't see the message telling them to run scripts/start_ray.sh... seeing the message multiple times is annoying, but this way might be worse.
robertnishihara
force-pushed
the
fixes
branch
from
5b35f9a
to
642423b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added printing for user to understand what the program is doing when nodes can't communicate.