Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Format Python code with Black #21975

Merged
merged 12 commits into from
Jan 30, 2022
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jan 29, 2022

This PR formats all Python files with Black, and adds noqa comments where necessary.

Why are these changes needed?

See #21316 and #21311 for the motivation behind these changes.

Related issue number

Closes #21316. Also see #21311.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz merged commit 7f1bacc into ray-project:master Jan 30, 2022
@bveeramani bveeramani deleted the black-format branch January 30, 2022 03:17
dmatrix pushed a commit to dmatrix/ray that referenced this pull request Jan 30, 2022
kfstorm pushed a commit that referenced this pull request Apr 21, 2022
- We should use `--force-exclude` when we pass code path explicitly https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html?highlight=--force-exclude#command-line-options
- Recover the files in `python/ray/_private/thirdparty` which has been formatted in the PR #21975 by mistake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Format Python code with Black
8 participants