[Dashboard] Make dashboard / agent work in minimal ray installation 1/3. #21774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
approved these changes
Jan 21, 2022
edoakes
approved these changes
Jan 21, 2022
scv119
approved these changes
Jan 21, 2022
|
Yes correct! |
wuisawesome
approved these changes
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is the doc that explains how to achieve this: https://docs.google.com/document/d/12qP3x5uaqZSKS-A_kK0ylPOp0E02_l-deAbmm8YtdFw/edit?usp=sharing
The fully working e2e prototype is here (it passes all tests): cdad913
This PR is pure refactoring. Basically it moves some of util functions that require optional_deps to
optional_utilsso that optional deps' util functions are not used in the minimal installation. Look below to see the steps.Related issue number
Checks
scripts/format.shto lint the changes in this PR.