Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] upgrade grpc and boringssl #20919

Merged
merged 1 commit into from
Dec 7, 2021
Merged

[Core] upgrade grpc and boringssl #20919

merged 1 commit into from
Dec 7, 2021

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Dec 6, 2021

Why are these changes needed?

Upgrade these dependencies to their respective latest stable versions. The latest version of GRPC C++ API has marked the callback API stable.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

rkooo567
rkooo567 approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. Maybe we can start migrating to the callback apis. Clark has a PR to do that

@mwtian mwtian added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 7, 2021
@mwtian mwtian changed the title [Core] upgrade grpc, boringssl and rules_proto_grpc [Core] upgrade grpc and boringssl Dec 7, 2021
@fishbone fishbone merged commit dd3a4aa into ray-project:master Dec 7, 2021
@mwtian mwtian deleted the grpc branch December 7, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@rkooo567 rkooo567

@fishbone fishbone

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwtian @rkooo567 @fishbone