[Core] Fix Used Memory Calculation #20127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Nov 6, 2021
| # also be considered as unused memory | ||
| if hasattr(psutil_mem, "cached"): | ||
| used_gb -= psutil_mem.cached / (1024**3) | ||
| used_gb = psutil_mem.used / (1024**3) |
There was a problem hiding this comment.
Btw, note;
According to the doc; https://psutil.readthedocs.io/en/latest/
used: memory used, calculated differently depending on the platform and designed for informational purposes only. total - free does not necessarily match used.
available: the memory that can be given instantly to processes without the system going into swap. This is calculated by summing different memory values depending on the platform and it is supposed to be used to monitor actual memory usage in a cross platform fashion.
6 tasks
|
Failing tests seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
total=used+free+buffers+cache. Andavailableis not related to them all. It’s an estimation of how much memory is available for use without swapping.We shouldn't calculate used memory as
total-avail.Related issue number
Checks
scripts/format.shto lint the changes in this PR.