[RFC] Add tsan build mode #19971
Merged
[RFC] Add tsan build mode #19971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Nov 2, 2021
scv119
approved these changes
Nov 2, 2021
|
@edoakes @richardliaw can you approve? |
richardliaw
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This allows you to build Ray with tsan via
RAY_DEBUG_BUILD=tsan pip install -e . --verbose.After building, you can
LD_PRELOAD=/lib/x86_64-linux-gnu/libtsan.so.0 pythonto run Ray with tsan enabled. Here's an example tsan log of a simple ray task execution (seems we have some non-thread safe stats usage): https://gist.github.com/ericl/f062fc614731b2b2ccb15189db73aeb0