Revert "Address comments"

This reverts commit 53896b3.

.bazelrc

@@ -14,13 +14,12 @@ build:macos --copt="-g1"
 build:linux --cxxopt="-std=c++17"
 build:macos --cxxopt="-std=c++17"
 build:clang-cl --cxxopt="-std=c++17"
-build:msvc-cl --cxxopt="/std:c++17"
-build:windows --cxxopt="/std:c++17"
+build:msvc --cxxopt="/std:c++17"
 # This workaround is needed to prevent Bazel from compiling the same file twice (once PIC and once not).
 build:linux --force_pic
 build:macos --force_pic
 build:clang-cl --compiler=clang-cl
-build:msvc-cl --compiler=msvc-cl
+build:msvc --compiler=msvc-cl
 # `LC_ALL` and `LANG` is needed for cpp worker tests, because they will call "ray start".
 # If we don't add them, python's `click` library will raise an error.
 build --action_env=LC_ALL
@@ -39,7 +38,7 @@ build:windows --enable_runfiles
 build:linux --per_file_copt="-\\.(asm|S)$@-Werror"
 build:macos --per_file_copt="-\\.(asm|S)$@-Werror"
 build:clang-cl --per_file_copt="-\\.(asm|S)$@-Werror"
-build:msvc-cl --per_file_copt="-\\.(asm|S)$@-WX"
+build:msvc --per_file_copt="-\\.(asm|S)$@-WX"
 # Ignore warnings for protobuf generated files and external projects.
 build --per_file_copt="\\.pb\\.cc$@-w"
 build --per_file_copt="-\\.(asm|S)$,external/.*@-w"
@@ -52,7 +51,7 @@ build --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGRPC_BAZE
 # Don't generate warnings about kernel features we don't need https://github.com/ray-project/ray/issues/6832
 build:linux --per_file_copt="-\\.(asm|S)$,external/com_github_grpc_grpc/.*@-DGPR_MANYLINUX1"
 # Ignore wchar_t -> char conversion warning on MSVC
-build:msvc-cl --per_file_copt="external/boost/libs/regex/src/wc_regex_traits\\.cpp@-wd4244"
+build:msvc --per_file_copt="external/boost/libs/regex/src/wc_regex_traits\\.cpp@-wd4244"
 build --http_timeout_scaling=5.0
 build --verbose_failures
 build:iwyu --experimental_action_listener=https://:iwyu_cpp
@@ -178,7 +177,6 @@ build:debug --strip="never"
 # Undefined Behavior Sanitizer
 build:ubsan --strip=never
 build:ubsan --copt -fsanitize=undefined
-build:ubsan --copt -fno-sanitize=vptr
 build:ubsan --copt -fno-sanitize-recover=all
 build:ubsan --copt -g
 build:ubsan --linkopt -fsanitize=undefined

.buildkite/pipeline.gpu.yml

@@ -1,13 +1,3 @@
-# Todo: Enable once tests are available
-#- label: ":tv: :octopus: Tune GPU tests "
-# conditions: ["RAY_CI_TUNE_AFFECTED"]
-# commands:
-# - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
-# - TUNE_TESTING=1 ./ci/travis/install-dependencies.sh
-# - pip install -Ur ./python/requirements_ml_docker.txt
-# - ./ci/travis/env_info.sh
-# - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-flaky,gpu,gpu_only python/ray/tune/...
-
 - label: ":tv: :brain: RLlib: GPU Examples {A/B}"
  conditions: ["RAY_CI_RLLIB_AFFECTED"]
  commands:

.buildkite/pipeline.macos.yml

@@ -64,7 +64,7 @@ steps:
  commands:
  - *prelude_commands
  - TORCH_VERSION=1.6 ./ci/travis/install-dependencies.sh
- - bazel test --config=ci --test_env=CI $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-flaky,-flaky-mac,-post_wheel_build --
+ - bazel test --config=ci --test_env=CI $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-flaky,-flaky-mac --
  //:all python/ray/serve/... python/ray/dashboard/... -rllib/... -core_worker_test
  - *epilogue_commands
 
@@ -82,7 +82,7 @@ steps:
  - bazel test $(./scripts/bazel_export_options) --config=ci
  --test_env=CONDA_EXE --test_env=CONDA_PYTHON_EXE --test_env=CONDA_SHLVL --test_env=CONDA_PREFIX
  --test_env=CONDA_DEFAULT_ENV --test_env=CONDA_PROMPT_MODIFIER --test_env=CI
- --test_tag_filters=-kubernetes,-medium_size_python_tests_a_to_j,-medium_size_python_tests_k_to_z,-flaky,-flaky-mac
+ --test_tag_filters=-kubernetes,-jenkins_only,-medium_size_python_tests_a_to_j,-medium_size_python_tests_k_to_z,-flaky,-flaky-mac
  python/ray/tests/...
  - *epilogue_commands
 
@@ -91,7 +91,7 @@ steps:
  commands:
  - *prelude_commands
  - bazel test --config=ci $(./scripts/bazel_export_options) --test_env=CI
- --test_tag_filters=-kubernetes,medium_size_python_tests_a_to_j,-flaky,-flaky-mac
+ --test_tag_filters=-kubernetes,-jenkins_only,medium_size_python_tests_a_to_j,-flaky,-flaky-mac
  python/ray/tests/...
  - *epilogue_commands
 
@@ -100,7 +100,7 @@ steps:
  commands:
  - *prelude_commands
  - bazel test --config=ci $(./scripts/bazel_export_options) --test_env=CI
- --test_tag_filters=-kubernetes,medium_size_python_tests_k_to_z,-flaky,-flaky-mac
+ --test_tag_filters=-kubernetes,-jenkins_only,medium_size_python_tests_k_to_z,-flaky,-flaky-mac
  python/ray/tests/...
  - *epilogue_commands
 
@@ -110,7 +110,7 @@ steps:
  - *prelude_commands
  - ./ci/travis/install-dependencies.sh
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,flaky,flaky-mac
+ --test_tag_filters=-kubernetes,-jenkins_only,flaky,flaky-mac
  --test_env=CONDA_EXE
  --test_env=CONDA_PYTHON_EXE
  --test_env=CONDA_SHLVL

.buildkite/pipeline.yml

@@ -182,9 +182,7 @@
  - TORCH_VERSION=1.6 ./ci/travis/install-dependencies.sh
  - ./dashboard/tests/run_ui_tests.sh
  - bazel test --config=ci $(./scripts/bazel_export_options) python/ray/dashboard/...
- - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-post_wheel_build
- python/ray/serve/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) python/ray/serve/...
 
 - label: ":python: Minimal install"
  conditions: ["RAY_CI_PYTHON_AFFECTED"]
@@ -210,7 +208,7 @@
  # --test_tag_filters=flaky
  # -- //:all -rllib/... -core_worker_test
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,flaky
  --test_env=CONDA_EXE
  --test_env=CONDA_PYTHON_EXE
  --test_env=CONDA_SHLVL
@@ -222,38 +220,38 @@
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,-medium_size_python_tests_a_to_j,-medium_size_python_tests_k_to_z,-client_tests,-flaky,-post_wheel_build,-worker-container
+ --test_tag_filters=-kubernetes,-jenkins_only,-medium_size_python_tests_a_to_j,-medium_size_python_tests_k_to_z,-client_tests,-flaky,-post_wheel_build,-worker-container
  --test_env=CONDA_EXE
  --test_env=CONDA_PYTHON_EXE
  --test_env=CONDA_SHLVL
  --test_env=CONDA_PREFIX
  --test_env=CONDA_DEFAULT_ENV
  python/ray/tests/...
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,client_tests,-flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,client_tests,-flaky
  --test_env=RAY_CLIENT_MODE=1 --test_env=RAY_PROFILING=1
  python/ray/tests/...
 - label: ":python: (Medium A-J)"
  conditions: ["RAY_CI_PYTHON_AFFECTED"]
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,medium_size_python_tests_a_to_j,-flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,medium_size_python_tests_a_to_j,-flaky
  python/ray/tests/...
 - label: ":python: (Medium K-Z)"
  conditions: ["RAY_CI_PYTHON_AFFECTED"]
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - bazel test --config=ci $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,medium_size_python_tests_k_to_z,-flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,medium_size_python_tests_k_to_z,-flaky
  python/ray/tests/...
 - label: ":core: Debug Test"
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - pip uninstall -y ray
  - RAY_DEBUG_BUILD=debug ./ci/travis/ci.sh build
  - bazel test --config=ci-debug $(./scripts/bazel_export_options)
- --test_tag_filters=-kubernetes,debug_tests,-flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,debug_tests,-flaky
  python/ray/tests/...
 - label: ":core: (ASAN tests)"
  conditions: ["RAY_CI_PYTHON_AFFECTED"]
@@ -262,7 +260,7 @@
  - RLLIB_TESTING=1 ./ci/travis/install-dependencies.sh
  - bazel test --config=ci --config=asan $(./scripts/bazel_export_options)
  --config=asan-buildkite
- --test_tag_filters=-kubernetes,asan_tests,-flaky
+ --test_tag_filters=-kubernetes,-jenkins_only,asan_tests,-flaky
  --test_env=CONDA_EXE
  --test_env=CONDA_PYTHON_EXE
  --test_env=CONDA_SHLVL
@@ -464,16 +462,16 @@
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - TUNE_TESTING=1 ./ci/travis/install-dependencies.sh
- - bazel test --config=ci $(./scripts/bazel_export_options) --test_tag_filters=-example,-flaky,-py37,-soft_imports,-gpu_only python/ray/tune/...
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=example,-tf,-pytorch,-py37,-flaky,-soft_imports,-gpu_only python/ray/tune/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --test_tag_filters=-jenkins_only,-example,-flaky,-py37,-soft_imports python/ray/tune/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=example,-tf,-pytorch,-py37,-flaky,-soft_imports python/ray/tune/...
 
 - label: ":octopus: Tune tests and examples {2/2}"
  conditions: ["RAY_CI_TUNE_AFFECTED"]
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - TUNE_TESTING=1 ./ci/travis/install-dependencies.sh
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=tf,-pytorch,-py37,-flaky,-soft_imports,-gpu_only python/ray/tune/...
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,pytorch,-py37,-flaky,-soft_imports,-gpu_only python/ray/tune/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=tf,-pytorch,-py37,-flaky,-soft_imports python/ray/tune/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,pytorch,-py37,-flaky,-soft_imports python/ray/tune/...
 
 - label: ":octopus: Tune soft imports test"
  conditions: ["RAY_CI_TUNE_AFFECTED"]
@@ -488,10 +486,10 @@
  commands:
  - cleanup() { if [ "${BUILDKITE_PULL_REQUEST}" = "false" ]; then ./ci/travis/upload_build_info.sh; fi }; trap cleanup EXIT
  - SGD_TESTING=1 INSTALL_HOROVOD=1 ./ci/travis/install-dependencies.sh
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=tf,-pytorch,-py37,-flaky,-client,-gpu_only python/ray/util/sgd/...
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,pytorch,-py37,-flaky,-client,-gpu_only python/ray/util/sgd/...
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=client_unit_tests,-gpu_only --test_env=RAY_CLIENT_MODE=1 python/ray/util/sgd/...
- - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-gpu_only python/ray/util/sgd/v2/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=tf,-pytorch,-py37,-flaky,-client python/ray/util/sgd/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,pytorch,-py37,-flaky,-client python/ray/util/sgd/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=client_unit_tests --test_env=RAY_CLIENT_MODE=1 python/ray/util/sgd/...
+ - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only python/ray/util/sgd/v2/...
 
 - label: ":octopus: Tune/SGD/Modin/Dask tests and examples. Python 3.7"
  conditions: ["RAY_CI_TUNE_AFFECTED", "RAY_CI_SGD_AFFECTED"]

.buildkite/windows/install/bazel.ps1

@@ -1,4 +1,4 @@
-$Env:BAZEL_URL="https://github.com/bazelbuild/bazel/releases/download/4.2.1/bazel-4.2.1-windows-x86_64.zip"
+$Env:BAZEL_URL="https://github.com/bazelbuild/bazel/releases/download/3.2.0/bazel-3.2.0-windows-x86_64.zip"
 Write-Host ('Downloading {0} ...' -f $env:BAZEL_URL);
 [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;
 Invoke-WebRequest -Uri $env:BAZEL_URL -OutFile 'bazel.zip';

.clang-tidy

@@ -1,64 +1,27 @@
-# Disable the following checks with reasons in parenthesis:
-#
-# -bugprone-macro-parentheses (inconsistent style)
-# -google-readability-todo (potentially too restrictive)
+# Disable the following checks due to frequent false positives, noisiness,
+# inconsistent style with existing codebase and other reasons:
 # -misc-non-private-member-variables-in-classes (potentially too restrictive)
 # -misc-unused-parameters (can be cleaned up in batch and enabled)
 # -modernize-avoid-c-arrays (too restrictive)
-# -modernize-concat-nested-namespaces (inconsistent style)
 # -modernize-pass-by-value (too restrictive)
 # -modernize-return-braced-init-list (inconsistent style)
 # -modernize-use-emplace (more subtle behavior)
-# -modernize-use-nodiscard (too much noise)
 # -modernize-use-trailing-return-type (inconsistent style)
-# -modernize-avoid-bind (incorrect conversion)
-# -modernize-loop-convert (more subtle behavior)
-# -modernize-replace-disallow-copy-and-assign-macro (inconsistent style)
-# -modernize-make-unique (doesn't work with private constructor)
-# -modernize-make-shared (doesn't work with private constructor)
-# Other readability-* rules (potentially too noisy, inconsistent style)
-# Other rules not mentioned here or below (not yet evaluated)
 #
 # TODO: enable google-* and readability-* families of checks.
 Checks: >
  abseil-*,
  bugprone-*,
- -bugprone-macro-parentheses,
- google-*,
- -google-readability-todo,
  misc-*,
  -misc-non-private-member-variables-in-classes,
  -misc-unused-parameters,
  modernize-*,
  -modernize-avoid-c-arrays,
- -modernize-concat-nested-namespaces,
  -modernize-pass-by-value,
  -modernize-return-braced-init-list,
  -modernize-use-emplace,
- -modernize-use-nodiscard,
  -modernize-use-trailing-return-type,
- -modernize-avoid-bind,
- -modernize-loop-convert,
- -modernize-replace-disallow-copy-and-assign-macro,
- -modernize-make-unique,
- -modernize-make-shared,
  performance-*,
- readability-avoid-const-params-in-decls,
- readability-braces-around-statements,
- readability-const-return-type,
- readability-container-size-empty,
- readability-delete-null-pointer,
- readability-else-after-return,
- readability-implicit-bool-conversion,
- readability-make-member-function-const,
- readability-misleading-indentation,
- readability-misplaced-array-index,
- readability-named-parameter,
- readability-non-const-parameter,
- readability-redundant-*,
- readability-static-definition-in-anonymous-namespace,
- readability-string-compare,
- readability-suspicious-call-argument,
 
 CheckOptions:
  # Reduce noisiness of the bugprone-narrowing-conversions check.

.flake8

@@ -24,20 +24,4 @@ ignore =
  W605
  I
  N
- B001
- B002
- B003
- B004
- B005
- B007
- B008
- B009
- B010
- B011
- B012
- B013
- B014
- B015
- B016
- B017
 avoid-escape = no

.github/CODEOWNERS

@@ -18,9 +18,6 @@
 # Dependencies
 /python/setup.py @richardliaw @ericl @edoakes
 
-# Formatting tool
-/ci/travis/format.sh @richardliaw @ericl @edoakes
-
 # Python worker.
 #/python/ray/ @ray-project/ray-core-python
 #!/python/ray/tune/ @ray-project/ray-core-python
@@ -33,6 +30,7 @@
 /java/*/pom_template.xml @jovany-wang @kfstorm @raulchen
 /java/api/ @jovany-wang @kfstorm @raulchen
 
+
 # Ray Client
 /src/ray/protobuf/ray_client.proto @ijrsvt @ameerhajali @ckw017 @mwtian
 
@@ -41,14 +39,6 @@
 # Ray tune.
 /python/ray/tune/ @ray-project/ray-tune
 
-# Ray data.
-/python/ray/data/ @ericl @scv119
-/doc/source/data/ @ericl @scv119
-
-# Ray workflows.
-/python/ray/workflow/ @ericl @iycheng
-/doc/source/workflows/ @ericl @iycheng
-
 # RLlib.
 #/python/ray/rllib/ @ray-project/rllib
 

.github/workflows/main.yml

@@ -26,7 +26,7 @@ jobs:
  os: windows-2019
  python-version: 3.8
  # Can be 'msvc' or 'clang-cl'
- config: msvc-cl
+ config: msvc
  env:
  BAZEL_CONFIG: ${{ matrix.config }}
  PYTHON: ${{ matrix.python-version }}
@@ -111,6 +111,7 @@ jobs:
  TRAVIS_COMMIT: ${{ github.sha }}
  TRAVIS_JOB_ID: ${{ github.run_id }}
  run: |
+ # Multi thread in windowns for grpc not working now
  function clean_up() {
  echo "Performing cleanup"
  if [ "${GITHUB_EVENT_NAME}" != "pull_request" ]; then ./ci/travis/upload_build_info.sh; fi

.gitpod/Dockerfile

@@ -15,7 +15,7 @@ RUN set -x; apt update \
  && mv bazel.gpg /etc/apt/trusted.gpg.d/ \
  && echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | tee /etc/apt/sources.list.d/bazel.list \
  && apt update && apt install bazel-3.7.2 -y \
- && pip3 install cython==0.29.0 pytest pandas tree tabulate pexpect sklearn joblib yapf==0.23.0 flake8==3.9.1 mypy==0.782 flake8-quotes flake8-bugbear==21.9.2 setproctitle==1.1.10 psutil \
+ && pip3 install cython==0.29.0 pytest pandas tree tabulate pexpect sklearn joblib yapf==0.23.0 flake8==3.9.1 mypy==0.782 flake8-quotes setproctitle==1.1.10 psutil \
  && python3 -c 'print("startup --output_base=/workspace/ray/.bazel-cache\nstartup --host_jvm_args=-Xmx1800m\nbuild --jobs=6")' > /etc/bazel.bazelrc
 
 RUN update-alternatives --install /usr/local/bin/python python /usr/bin/python3 30 \