Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Dashboard][event] Basic event module" #17068

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Jul 14, 2021

Reverts #16985

Sorry I have to revert this again @fyrestone. This is causing Mac Wheel Build to fail

Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@amogkam amogkam merged commit c17e171 into master Jul 14, 2021
@amogkam amogkam deleted the revert-16985-improve_test_events branch July 14, 2021 06:18
@fyrestone
Copy link
Contributor

@amogkam Where can i find the build error log?

@amogkam
Copy link
Contributor Author

amogkam commented Jul 14, 2021

You can see it by clicking on the bug icon on the flaky test tracker https://flakey-tests.ray.io/

@fyrestone
Copy link
Contributor

fyrestone commented Jul 14, 2021

You can see it by clicking on the bug icon on the flaky test tracker https://flakey-tests.ray.io/

There are many errors in the build log, but none of them related to this PR. P.S. many failed builds have no output.

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@fyrestone
Copy link
Contributor

fyrestone commented Jul 14, 2021

@amogkam I found some worker crashes in this build log: https://travis-ci.com/github/ray-project/ray/jobs/524307882

[2021-07-14 04:57:17,712 C 11573 47781] core_worker.cc:207:  Check failed: core_worker_process The core worker process is not initialized yet or already shutdown.
*** StackTrace Information ***
    ray::GetCallTrace()
    ray::SpdLogMessage::Flush()
    ray::RayLog::~RayLog()
    ray::CoreWorkerProcess::EnsureInitialized()
    ray::CoreWorkerProcess::GetCoreWorker()
    __pyx_pw_3ray_7_raylet_10CoreWorker_21get_worker_id()
    method_vectorcall_NOARGS
    call_function
    _PyEval_EvalFrameDefault
    function_code_fastcall
    property_descr_get
    _PyObject_GenericGetAttrWithDict
    _PyEval_EvalFrameDefault
    function_code_fastcall
    call_function
    _PyEval_EvalFrameDefault

I am not sure if it is the root cause of the failure. Some other errors are caused by missing psutil.

=================================== FAILURES ===================================
___________________________ test_user_setup_function ___________________________
    @pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows")
    def test_user_setup_function():
        script = """
    import ray
    ray.init()
    @ray.remote
    def get_pkg_dir():
        return ray._private.runtime_env.VAR
    
    print("remote", ray.get(get_pkg_dir.remote()))
    print("local", ray._private.runtime_env.VAR)
    
    
    """
    
        out = run_string_as_driver(
            script, {"RAY_USER_SETUP_FUNCTION": "ray.test_utils.set_setup_func"})
        (remote_out, local_out) = out.strip().split("\n")[-2:]
>       assert remote_out == "remote hello world"
E       AssertionError: assert '\x1b[2m\x1b[...import psutil' == 'remote hello world'
E         - remote hello world
E         + (raylet)     import psutil
python/ray/tests/test_basic.py:215: AssertionError

The build log also shows the redis failure:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 1198, in get_connection
    if connection.can_read():
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 734, in can_read
    return self._parser.can_read(timeout)
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 416, in can_read
    return self.read_from_socket(timeout=timeout,
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 429, in read_from_socket
    raise ConnectionError(SERVER_CLOSED_CONNECTION_ERROR)
redis.exceptions.ConnectionError: Connection closed by server.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 559, in connect
    sock = self._connect()
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 615, in _connect
    raise err
  File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/redis/connection.py", line 603, in _connect
    sock.connect(socket_address)
ConnectionRefusedError: [Errno 61] Connection refused

@fyrestone
Copy link
Contributor

fyrestone commented Jul 14, 2021

@amogkam @zhe-thoughts The event module is disabled by default, it is only enabled in the test_event.py. I need more clues about the build failure.

@fyrestone
Copy link
Contributor

@amogkam I noticed that the mac wheel build still fails after the revert. I think it's better to show the error details in the build log, so that we can fix it quickly. Currently, I don't know which error caused the build to fail.

@amogkam
Copy link
Contributor Author

amogkam commented Jul 15, 2021

You're right @fyrestone this isn't causing the failures. We can merge back in.

@fyrestone
Copy link
Contributor

You're right @fyrestone this isn't causing the failures. We can merge back in.

Thanks.

raulchen pushed a commit that referenced this pull request Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants