[Core] Get node to connect for driver in global state accessor #16810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide an explanation about what this is and why we need it? |
|
@wuisawesome Sorry I didn't add a description because it was too late last night. Please see the PR description. |
qicosmos
reviewed
Jul 2, 2021
| boost::asio::ip::udp::resolver::iterator endpoints = resolver.resolve(query); | ||
| boost::asio::ip::udp::endpoint ep = *endpoints; | ||
| boost::asio::ip::udp::socket socket(netService); | ||
| socket.connect(ep); |
There was a problem hiding this comment.
We'd better use a timeout here, and handle failure.
There was a problem hiding this comment.
The original Python code doesn't have a timeout either, and I already handled failure via try-catch.
|
Can you merge master and fix the conflicting files? |
SongGuyang
reviewed
Jul 5, 2021
WangTaoTheTonic
approved these changes
Jul 7, 2021
| } | ||
| } | ||
|
|
||
| if (!status.IsNotFound()) { |
There was a problem hiding this comment.
This check can be removed.
SongGuyang
approved these changes
Jul 7, 2021
wuisawesome
approved these changes
Jul 7, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When a driver starts, it needs to figure out the node manager port, the Raylet socket file path, and the Plasma store socket file path to be able to connect to the local Raylet. (A worker doesn't need this step because the information is included in worker command-line arguments.) This step is required by all language bindings. Currently, the logic is implemented in Python, which makes it hard to be reused by Java and C++ bindings.
In this PR, we move this logic to C++ code (global state accessor) to make it shared by all language bindings.
This PR also removes the mandatory and hardcoded
--node-manager-port 62665parameter forray start --headwhen users try the C++ API.Related issue number
#16735
Checks
scripts/format.shto lint the changes in this PR.