[nightly test] add nightly test for placement_group #16633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Jun 23, 2021
| export PATH="/home/ray/bin:$PATH" | ||
|
|
||
| cd ~/ray/ci/asan_tests/ && bash ./run.sh --git-sha="${GIT_COMMIT}" | ||
| popd || echo '{"succss": 1}' > "${TEST_OUTPUT_JSON}" |
| @@ -207,3 +207,31 @@ | |||
| smoke_test: | |||
| cluster: | |||
| compute_template: shuffle/shuffle_compute_smoke.yaml # Does not exist yet | |||
|
|
|||
| # Stress tests with many tasks | |||
| - name: stress_test_replacement_group | |||
There was a problem hiding this comment.
Btw, this is placement_group not replacemet_group.
| # Stress tests with many tasks | ||
| - name: stress_test_replacement_group | ||
| cluster: | ||
| app_config: stress_tests/stress_tests_app_config.yaml |
There was a problem hiding this comment.
We don't need the stress test cluster. The pg stress test just is running in a single node.
7419cba
to
9885232
Compare
scv119
commented
Jun 24, 2021
| resources: | ||
| cpu: 64 | ||
|
|
||
| worker_node_types: |
There was a problem hiding this comment.
@rkooo567 we created 5 worker nodes as the test_replacement group is attaching to prod cluster instead of local started simulating clusters; let me know if this makes sense.
There was a problem hiding this comment.
Oh I see. Yeah this is actually better sgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, add nightly tests for test_placement_group and ASAN tests.
placement group test passed