[DataFrame] Adding error checking for pandas version #1662
Conversation
python/ray/dataframe/__init__.py
Outdated
| @@ -2,6 +2,15 @@ | |||
| from __future__ import division | |||
| from __future__ import print_function | |||
| import threading | |||
| import pandas as pd | |||
There was a problem hiding this comment.
while we're at it, can we keep these in alphabetical order (and also add a newline before the first import?
python/ray/dataframe/__init__.py
Outdated
| pd_major = int(pd_version.split(".")[0]) | ||
| pd_minor = int(pd_version.split(".")[1]) | ||
|
|
||
| if pd_major != 0 or pd_minor < 22: |
There was a problem hiding this comment.
This will fail with 1.0.0 (which doesn't exist yet of course), but why not
if pd_major == 0 and pd_minor < 22:There was a problem hiding this comment.
Sure I can change it.
python/ray/dataframe/__init__.py
Outdated
|
|
||
| if pd_major != 0 or pd_minor < 22: | ||
| raise Exception("In order to use Pandas on Ray, please upgrade your Pandas" | ||
| " version to >= 0.22.") |
There was a problem hiding this comment.
this will only happen if we import ray.dataframe right? and not if we just do import ray
|
Test PASSed. |
|
Test PASSed. |
Resolves #1660