Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll forward to run train_small in client mode. #16610

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

mwtian
Copy link
Member

@mwtian mwtian commented Jun 22, 2021

Why are these changes needed?

Releaser now has basic support to install Ray with version matching that in cluster env (ray-project/releaser@bbd4f2d), and other dependencies from cluster env (app config). This has been verified by running from laptop.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@AmeerHajAli AmeerHajAli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will refer to @krfricke .

@AmeerHajAli AmeerHajAli added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 22, 2021
@mwtian mwtian removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 23, 2021
@mwtian
Copy link
Member Author

mwtian commented Jun 23, 2021

This is verified to work with releaser on buildkite: https://buildkite.com/ray-project/periodic-ci/builds/335

@AmeerHajAli
Copy link
Contributor

@krfricke can you please advise on next steps?

Copy link
Contributor

@AmeerHajAli AmeerHajAli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @krfricke , is this ok to merge?

@krfricke krfricke merged commit 48599ae into ray-project:master Jun 23, 2021
@mwtian mwtian deleted the train_small branch June 23, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants