Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] Move Ape-X metrics behind a debug flag and remove some of them #1656

Merged
merged 3 commits into from
Mar 8, 2018
Merged

[rllib] Move Ape-X metrics behind a debug flag and remove some of them #1656

merged 3 commits into from
Mar 8, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 5, 2018 •
edited
Loading

What do these changes do?

Cleans up Ape-X stats collection; some of the previous metrics were a bit gratuitous. Now it reduces to

  info:
    max_exploration: 0.4
    min_exploration: 0.0006553600000000003
    num_steps_sampled: 1000
    num_steps_trained: 0
    num_target_updates: 0
    num_weight_syncs: 2
    sample_throughput: 202.244
    train_throughput: 0.0

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4133/
Test PASSed.

richardliaw
richardliaw approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 naming nit

python/ray/rllib/utils/actors.py Outdated
@@ -25,6 +25,13 @@ def count(self):
return len(self._tasks)


def keep_non_colocated(actors):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to drop_colocated to reduce double negatives?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4150/
Test PASSed.

@richardliaw richardliaw merged commit 75e8251 into ray-project:master Mar 8, 2018
@richardliaw richardliaw deleted the simplify-apex branch March 8, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @richardliaw