Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update to expose libraries + landing page #1642

Merged
merged 17 commits into from
Mar 8, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 2, 2018

What do these changes do?

This reorganizes the tune docs to give important algorithms their own page (we should add more as new algorithms are added). This should hopefully help with SEO -- currently if you search for "HyperBand" the tune docs don't even show up in the first couple pages. However if you search for "A3C" or "Rllib" those terms already rank highly.

lbs

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4078/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4076/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4077/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4079/
Test PASSed.

@richardliaw
Copy link
Contributor

richardliaw commented Mar 4, 2018

Somehow it might be nice to indicate that HyperBand isn't a library, as with PBT. I do believe these things are worth highlighting and am not sure about the right formatting.

@robertnishihara @pcmoritz @concretevitamin @vlad17 any thoughts?

@ericl
Copy link
Contributor Author

ericl commented Mar 4, 2018

Yeah I don't know if readthedocs has some syntax for a nested page.

@richardliaw
Copy link
Contributor

screenshot 2018-03-06 17 48 13

@robertnishihara
Copy link
Collaborator

seems good to me

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4158/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4159/
Test PASSed.

@richardliaw richardliaw changed the title [tune] update docs to split algorithms into separate pages [tune] update docs to expose libraries + update landing page Mar 7, 2018
@richardliaw richardliaw changed the title [tune] update docs to expose libraries + update landing page [docs] update to expose libraries + landing page Mar 7, 2018
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericl, should do a read over my changes before merge

Asynchronous HyperBand
----------------------

Ray Tune also implements an `asynchronous version of HyperBand <https://openreview.net/forum?id=S1Y7OOlRZ>`__, providing better parallelism and avoids straggler issues during eliminations. An example of this can be found in `async_hyperband_example.py <https://github.com/ray-project/ray/blob/master/python/ray/tune/examples/async_hyperband_example.py>`__. **We recommend using this over the vanilla HyperBand scheduler.**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we recommend this as the default one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordered the docs so that it shows up first


.. image:: images/hyperband_eta.png

We figured that it would be a lot easier for majority of people to use if we fixed the parameters to be the same as the example given in the paper and only exposed `max_t`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing sounds more like a blog post, reword for documentation?

Copy link
Contributor Author

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple comments on phrasing

@richardliaw
Copy link
Contributor

richardliaw commented Mar 8, 2018

addressed comments and tweaked a little more; I'll merge for now after tests pass(as there are no substantial changes) but if there are issues we can just patch it.

@ericl
Copy link
Contributor Author

ericl commented Mar 8, 2018

Sounds good!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4196/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4197/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4198/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4200/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4205/
Test PASSed.

@richardliaw richardliaw merged commit d85274a into ray-project:master Mar 8, 2018
@richardliaw richardliaw deleted the tune-docs-update branch March 8, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants