Make it much simpler to turn on event stats #16401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Jun 14, 2021
|
The java segfault should be a known bug |
rkooo567
added
the
@author-action-required
clarkzinzow
approved these changes
Jun 14, 2021
|
@rkooo567 @ericl Could you update any context? |
|
I believe this is still causing segfaults when enabled by default in some tests, perhaps due to thread safety issues / TSAN issues with the stats collection code. One issue is this: #19747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Now just setting
RAY_event_stats=1is all you need for event debugging.