Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] Bad error message when dict field omitted #1632

Merged
merged 2 commits into from
Mar 4, 2018
Merged

[autoscaler] Bad error message when dict field omitted #1632

merged 2 commits into from
Mar 4, 2018

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Mar 1, 2018

What do these changes do?

This is because a dictionary instance is not a type and has no name.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4059/
Test PASSed.

@ericl
Copy link
Contributor Author

ericl commented Mar 4, 2018

Valgrind leak is unrelated.

@ericl ericl merged commit 9b33f3a into ray-project:master Mar 4, 2018
@richardliaw richardliaw deleted the fix-typo branch March 4, 2018 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericl @AmplabJenkins @richardliaw