Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Reorganize dashboard modules - snapshot #16306

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[Dashboard] Reorganize dashboard modules - snapshot #16306

merged 1 commit into from
Jun 8, 2021

Conversation

fyrestone
Copy link
Contributor

Why are these changes needed?

  • Move test_snapshot from test_dashboard.py to modules/snapshot/tests/test_snapshot.py. The test case should be in the module.

Related issue number

#14766

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fyrestone fyrestone added the dashboard Issues specific to the Ray Dashboard label Jun 8, 2021
@fyrestone fyrestone added this to the Dashboard Improvements milestone Jun 8, 2021
@fyrestone fyrestone self-assigned this Jun 8, 2021
@simon-mo simon-mo requested a review from wuisawesome June 8, 2021 17:22
@wuisawesome wuisawesome merged commit 4ca316a into ray-project:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuisawesome wuisawesome wuisawesome approved these changes

Assignees

@fyrestone fyrestone

Labels
dashboard Issues specific to the Ray Dashboard
Projects
None yet
Milestone
Dashboard Improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@fyrestone @wuisawesome