Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard][event] Basic event module #16283

Merged
merged 6 commits into from
Jun 25, 2021
Merged

[Dashboard][event] Basic event module #16283

merged 6 commits into from
Jun 25, 2021

Conversation

fyrestone
Copy link
Contributor

@fyrestone fyrestone commented Jun 7, 2021 •
edited
Loading

Why are these changes needed?

The basic event module to collect events from all nodes. It provides a RESTful API for frontend to get events.

Limits: The dashboard does not persistence the event data.

proposal: https://docs.google.com/document/d/1I_0rcZmQHsjHrWi3UVSgxYcRDr8OEcDnenCdryMQwrM/edit#

Related issue number

Closes #16246

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fyrestone fyrestone added the dashboard Issues specific to the Ray Dashboard label Jun 7, 2021
@fyrestone fyrestone added this to the Event Framework milestone Jun 7, 2021
@fyrestone fyrestone self-assigned this Jun 7, 2021
@rkooo567
Copy link
Contributor

rkooo567 commented Jun 8, 2021

Hey @fyrestone Can we bring this up to the sync up meeting before we proceeds with the PR?

@fyrestone
Copy link
Contributor Author

Hey @fyrestone Can we bring this up to the sync up meeting before we proceeds with the PR?

OK

@rkooo567 rkooo567 added the do-not-merge Do not merge this PR! label Jun 9, 2021
@rkooo567
Copy link
Contributor

rkooo567 commented Jun 9, 2021

Pending merging PR until we discuss in the sync meeting cc @edoakes

@rkooo567 rkooo567 self-assigned this Jun 9, 2021
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 10, 2021
@fyrestone fyrestone removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jun 22, 2021
@raulchen raulchen merged commit 5afa53a into ray-project:master Jun 25, 2021
@raulchen raulchen deleted the basic_dashboard_event_module branch June 25, 2021 05:59
architkulkarni added a commit that referenced this pull request Jun 25, 2021
@architkulkarni
Revert "[Dashboard][event] Basic event module (#16283)"
eaa7fe7 
This reverts commit 5afa53a.
@architkulkarni architkulkarni mentioned this pull request Jun 25, 2021
Merged
amogkam pushed a commit that referenced this pull request Jun 25, 2021
@architkulkarni
Revert "[Dashboard][event] Basic event module (#16283)" (#16676)
06dfd8d 
This reverts commit 5afa53a.
@fyrestone fyrestone mentioned this pull request Jun 28, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@fyrestone fyrestone

@rkooo567 rkooo567

Labels
dashboard Issues specific to the Ray Dashboard do-not-merge Do not merge this PR!
Projects
None yet
Milestone
Event Framework
Development

Successfully merging this pull request may close these issues.

[Dashboard][event] Basic event module
4 participants
@fyrestone @rkooo567 @edoakes @raulchen