Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataframes] Implement __repr__ and __str__ #1628

Merged
merged 1 commit into from
Mar 2, 2018
Merged

[Dataframes] Implement __repr__ and __str__ #1628

merged 1 commit into from
Mar 2, 2018

Conversation

kunalgosar
Copy link
Contributor

This PR implements repr and str on the Dataframes. It also fixes a bug that I caught in the tail fn.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4029/
Test PASSed.

devin-petersohn
devin-petersohn approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, Thanks @kunalgosar !

@devin-petersohn
Copy link
Member

Passed private-travis. Thanks @kunalgosar

@devin-petersohn devin-petersohn merged commit 6685d4c into ray-project:master Mar 2, 2018
@kunalgosar kunalgosar deleted the repr_str branch March 2, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

Assignees
No one assigned
Labels
usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kunalgosar @AmplabJenkins @devin-petersohn @anyscalesam