[DataFrame] Pass lengths to _default_index instead of df #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test PASSed. |
devin-petersohn
approved these changes
Feb 27, 2018
| @@ -1321,7 +1323,8 @@ def _maybe_casted_values(index, labels=None): | |||
| values, mask, np.nan) | |||
| return values | |||
|
|
|||
| new_index = ray.get(_default_index.remote(new_obj)).index | |||
| _, new_index = _compute_length_and_index.remote(new_obj._df) | |||
There was a problem hiding this comment.
The trouble here is that we're recomputing the lengths, but they should already be known. We can optimize this later.
|
Passed private-travis. OK to merge. Thanks @kunalgosar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the DataFrame to the remote function caused a significant performance regression, due to serialization. This passes in just the length object instead.
This also moves the lengths computation to the same remote function. This way all expensive metadata computation is asynchronous.