[Tune] Add find_free_port Tune util #16098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdeng
reviewed
May 27, 2021
| @@ -1,14 +1,14 @@ | |||
| from ray.tune.utils.util import ( | |||
There was a problem hiding this comment.
When do/don't we add references in this file? For example, the atomic_save function is not defined here.
There was a problem hiding this comment.
I don't think there's a convention for this either, I think atomic_save was probably just forgotten to be included. @richardliaw?
matthewdeng
reviewed
May 27, 2021
| @@ -484,6 +486,14 @@ def atomic_save(state: Dict, checkpoint_dir: str, file_name: str, | |||
| os.replace(tmp_search_ckpt_path, os.path.join(checkpoint_dir, file_name)) | |||
|
|
|||
|
|
|||
| def find_free_port(): | |||
There was a problem hiding this comment.
Is there a convention for where new functions should be, e.g. end of file?
There was a problem hiding this comment.
No convention; usually locally grouped by similarity
matthewdeng
approved these changes
May 27, 2021
|
Failing test is flaky and unrelated, going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Tune specific
find_free_portutil to use for the Tensorflow integration.Previously, importing the function from SGD would log this warning if torch is not installed
"PyTorch not found. TorchTrainer will not be available"which is confusing for users who want to use Tensorflow Tune.Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.