Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++ worker] support config from RayConfig and command line(gflag) #16086

Merged
merged 13 commits into from
May 31, 2021
Merged

[C++ worker] support config from RayConfig and command line(gflag) #16086

merged 13 commits into from
May 31, 2021

Conversation

SongGuyang
Copy link
Contributor

Why are these changes needed?

  • This is a C++ API configuration refactor.
  • Users can use Ray::Init with a RayConfig, like Ray::Init(config).
  • Another way of configuration will be supported: Set internal config params in command line(like "--dynamic-library-path=bazel-bin/cpp/example/example.so --redis-address=127.0.0.1:6379"). And put argc and argv to RayConfig.
  • Command line parameters have higher priority.

@qicosmos qicosmos self-requested a review May 27, 2021 03:16
qicosmos
qicosmos approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kfstorm
kfstorm reviewed May 27, 2021
View reviewed changes
cpp/include/ray/api/ray_config.h Outdated Show resolved Hide resolved
cpp/include/ray/api/ray_config.h Show resolved Hide resolved
cpp/include/ray/api/ray_config.h Outdated Show resolved Hide resolved
cpp/include/ray/api/ray_config.h Outdated Show resolved Hide resolved
cpp/include/ray/api/ray_config.h Outdated Show resolved Hide resolved
cpp/src/ray/ray_config_internal.cc Outdated Show resolved Hide resolved
cpp/src/ray/ray_config_internal.cc Outdated Show resolved Hide resolved
cpp/src/ray/ray_config_internal.cc Outdated Show resolved Hide resolved
cpp/src/ray/ray_config_internal.cc Outdated Show resolved Hide resolved
cpp/src/ray/ray_config_internal.cc Outdated Show resolved Hide resolved
@kfstorm
Copy link
Member

kfstorm commented May 27, 2021

BTW, we need to add ray_ prefix for all ray-defined flags.

kfstorm
kfstorm reviewed May 28, 2021
View reviewed changes
cpp/example/example.cc Outdated Show resolved Hide resolved
cpp/include/ray/api/ray_config.h Outdated Show resolved Hide resolved
kfstorm
kfstorm approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@kfstorm kfstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfstorm kfstorm merged commit 17b5f4d into ray-project:master May 31, 2021
@kfstorm kfstorm deleted the dev_cpp_worker_config branch May 31, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qicosmos qicosmos qicosmos approved these changes

@kfstorm kfstorm kfstorm approved these changes

@AmeerHajAli AmeerHajAli Awaiting requested review from AmeerHajAli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SongGuyang @kfstorm @qicosmos